[PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

[Alberto Milone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/12/13 19:51, Keith Packard wrote:
> Alberto Milone <alberto.milone at canonical.com> writes:
> 
>> +    if (pScreen->isGPU) { +        master = 
>> pScreen->current_master; +        if (!master) + return; +
>> mastersp = rrGetScrPriv(master); } +    else { + master =
>> pScreen; +        mastersp = pScrPriv; +    } + + 
>> RRSetChanged(pScreen);
> 
> Don't you want to pass 'master' here?

I thought about it but I also thought that RRSetChanged() would get
master anyway.

The potential benefit of passing the gpu screen is that if we ever
wanted to do something on the gpu screen in RRSetChanged() (other than
setting screen->changed to TRUE) before getting master, we could do that.

If you think that RRSetChanged() will always just set master->changed
(as the name of the function suggests), then I guess we should simply
pass master instead.


- -- 
Alberto Milone
Software Engineer
Hardware Enablement Team
Professional and Engineering Services
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlKo1vMACgkQFZJJ6Y6yavFjwwCgxdHU4xU56mIoURv3Owy2UA+D
QlUAnR0lN2TTWeTNWU9Y/Rdp6h/z9MJT
=wpQM
-----END PGP SIGNATURE-----