[PATCH 3/3] present: Don't use the major/minor version from the protocol headers

[Jasper St. Pierre]

OK then. Thanks for the explanation.

Reviewed-by: Jasper St. Pierre <jstpierre at mecheye.net>


On Fri, Dec 13, 2013 at 1:45 PM, Adam Jackson <ajax at redhat.com> wrote:

> On Fri, 2013-12-13 at 13:13 -0500, Jasper St. Pierre wrote:
> > So, I know this is existing practice, but it seems to me that building
> > with different protocol headers than what the server supports would
> > only lead to disaster.
>
> If the structs or enums changed, sure, but if that ever happens we're
> already in disaster territory.
>
> > Do we do this anywhere already?
>
> I pretty routinely update the protocol headers in older Fedoras so I can
> build git xservers on released OSes.  And it's really nice for bisection
> to not need to lockstep the protocol headers with the server, where by
> really nice I mean the alternative would be infuriating.
>
> We haven't always done the <protocol-versions.h> thing; that it's there
> now is because it fixed a class of bugs we really did hit in the wild.
>
> - ajax
>
>
>


-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131213/7746f816/attachment.html>