[PATCH 40/44] include: GetClientResolutions is declared in font.h

Alan Coopersmith alan.coopersmith at oracle.com
Fri Dec 13 13:09:36 PST 2013


On 12/11/13 10:47 PM, Keith Packard wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
>> On 12/11/13 12:24 PM, Keith Packard wrote:
>>> No need to have a duplicate definition here.
>>>    include/dixfontstubs.h | 2 --
>>
>> But the comment at the top of the header says nothing includes it,
>> it's just there for sdksyms to use, so why does this reduce warnings?
>>
>> git grep doesn't find any uses outside of hw/xfree86/sdksyms.sh.
>
> sdksyms also includes font.h from fontsproto, which also declares
> GetClientResolutions, so when you build the resulting sdksyms.c, you get
> a duplicate definition.

Ah right, digging back into the history, found the previous fixes here
said the duplication was now limited to GetClientResolutions to avoid
having to change fontsproto to match.

Unfortunately, I don't remember off hand what, if anything, needs the
GetClientResolutions symbol exported from the server, so unless someone
wants to verify it's not needed, I'd like to see sdksyms continue to
export the symbol - as long as that happens, I'm happy.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list