[PATCH 28/44] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print _X_ATTRIBUTE_PRINTF

Keith Packard keithp at keithp.com
Fri Dec 13 14:23:31 PST 2013


Mark Kettenis <mark.kettenis at xs4all.nl> writes:

> It makes much more sense to consistently print drm_context_t as %u or
> 0x%x.  It's an unsigned int on both OpenBSD and Linux, so I suspect
> that's the case everywhere.

I'd like to keep the warning patches separate from semantic changes like
this; I think it's easier to review them when you know they're not
supposed to actually change what the code does, just inform the
compiler.

A separate patch which fixes the printf format seems like a fine plan though.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131213/22e25ed8/attachment.pgp>


More information about the xorg-devel mailing list