[PATCH RESEND] xfree86: Keep a non-seat0 X server from touching VTs (#71258)

[Laércio de Sousa]

Hans, could you please consider this other patch from Oleg Samarin, too?
It's important in order to set up multiseat properly when the secondary
graphics devices are not KMS-compliant (e.g. NVIDIA/AMD graphics cards with
proprietary drivers), and the display manager doesn't allow passing a
custom "-config" option to X server (e.g. GDM).

http://lists.x.org/archives/xorg-devel/2013-September/037946.html

It introduces a new MatchSeat key for sections "Device", "Screen", and
"ServerLayout" in xorg.conf. The most common case is having a single file
e.g. /etc/X11/xorg.conf.d/90-seat.conf of kind

Section "Device"
    Identifier "card1"
    Driver "nvidia"
    MatchSeat "seat-1"
EndSection

If one needs to include also a "Screen" section, both "Device" and "Screen"
sections must have a MatchSeat key with the same value. Here's an example
from my real setup:

Section "Device"
    Identifier "videocard_sm501"
    BusID "PCI:4:1:0"
    Driver "siliconmotion"
    Option "PanelSize" "1360x768"
    MatchSeat "seat-thinnet"
EndSection

Section "Screen"
    Identifier "screen_sm501"
    Device "videocard_sm501"
    DefaultDepth 16
    MatchSeat "seat-thinnet"
EndSection

In one of my previous tests, putting a MatchSeat entry in "ServerLayout"
section made X server segfault. I'll repeat my tests soon.

Thanks in advance!

CANTATE DOMINO CANTICUM NOVUM
QUIA MIRABILIA FECIT

Laércio


2013/12/12 Hans de Goede <hdegoede at redhat.com>

> Hi,
>
>
> On 12/12/2013 05:22 PM, Laércio de Sousa wrote:
>
>> Updated patch following Hans de Goede's advice.
>>
>
> Thanks, added to my tree with the 2 elements of the test swapped
> as discussed. I've also changed the test from:
>
> if (!((flags & HW_SKIP_CONSOLE) || ServerIsNotSeat0()))
>
> to:
>
> if (!(flags & HW_SKIP_CONSOLE) && !ServerIsNotSeat0()))
>
> Because the amount of parenthesis in the former was making
> it hard on the eyes IMHO.
>
> You can find it here for now:
> http://cgit.freedesktop.org/~jwrdegoede/xserver
>
> After the 1.15 release I'll send a pull request for this to
> get added into xserver git master.
>
> Regards,
>
> Hans
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131216/faafad83/attachment.html>