[PATCH libXt 1/2] Fix cross-compilation

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jan 3 07:59:00 PST 2013


On 01/ 3/13 07:41 AM, Thierry Reding wrote:
> On Thu, Jan 03, 2013 at 04:32:45PM +0100, Thomas Petazzoni wrote:
>> Dear Thierry Reding,
>>
>> On Thu,  3 Jan 2013 10:16:55 +0100, Thierry Reding wrote:
>>> When cross-compiling against a sysroot for instance, a --sysroot
>>> option is typically passed via the CPPFLAGS variable. This can cause
>>> the build to break in the util subdirectory which requires the
>>> CPPFLAGS to be set for the build system.
>>>
>>> Solve this by using the value of CPPFLAGS_FOR_BUILD for CPPFLAGS in
>>> the util subdirectory. Cross-compile setups can override the variable
>>> when calling teh configure script.
>>>
>>> Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>
>>
>> I also sent a libXt cross-compilation fix a while ago, but it was never
>> applied:
>>
>> Subject: [PATCH] libXt: util: don't link makestrs with target cflags
>> Date: Fri, 16 Nov 2012 10:41:06 +0100
>>
>> Hopefully it will get applied some day.
> 
> Right, I remember seeing that. Let's see if somebody notices. If not we
> probably have to find out who needs to be prodded to get the patches
> merged.

You could start by prodding each other to review your patches and responding
with a "Reviewed-by" tag for them.

(Not that it will create a libXt maintainer, just slightly encourage those of
 us with commit access to push the patches anyway.)

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list