[PATCH] libXt: util: don't link makestrs with target cflags

Thierry Reding thierry.reding at avionic-design.de
Thu Jan 3 12:29:52 PST 2013

On Fri, Nov 16, 2012 at 10:41:06AM +0100, Thomas Petazzoni wrote:
> The line:
> in util/Makefile.am is wrong because it adds target cflags to the
> compilation of makestrs, which is built for the build machine, which
> leads to build failures when cross-compiling.
> We also remove the inclusion of <X11/Xos.h> from makestrs.c, because
> it was the only non-standard header being included (and therefore
> possibly requiring special cflags), but it was in reality not useful
> at all to build makestrs.c.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

With Jon's comment addressed, this patch is:

Reviewed-by: Thierry Reding <thierry.reding at avionic-design.de>
Tested-by: Thierry Reding <thierry.reding at avionic-design.de>

I've tested for x86_64 -> x86 and for x86_64 -> ARM cross-builds.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130103/6a9a6157/attachment.pgp>

More information about the xorg-devel mailing list