[PATCH] hw/xfree86: Only report SetDesiredModes() failed if at least one modeset fails

Keith Packard keithp at keithp.com
Wed Jan 9 22:33:34 PST 2013

Chris Wilson <chris at chris-wilson.co.uk> writes:

> commit 6703a7c7cf1a349c137e247a0c8eb462ff7b07be
> Author: Keith Packard <keithp at keithp.com>
> Date:   Tue Jan 8 20:24:32 2013 -0800
>     hw/xfree86: Require only one working CRTC to start the server.
> changed the logic to try to set the mode on all connected outputs rather
> than abort upon the first failure. The return error code was then
> tweaked such that it reported success if it set a mode on any crtc.
> However, this confuses the headless case where we never enable any crtcs
> and also, importantly, never fail to set a crtc.

Oops. Nice catch. So, we fail only if there are outputs and none have
managed to be configured.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130109/852cc2fd/attachment.pgp>

More information about the xorg-devel mailing list