[PATCH:xfs 3/7] Convert UseFPE & FreeFPE into static inline functions

Alan Coopersmith alan.coopersmith at oracle.com
Sat Jan 19 23:03:51 PST 2013


Comment suggests making them a macro, but since they're only used in this
file, might as well let the compiler choose how best to optimize them.

Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
 difs/fonts.c   |    5 ++---
 include/difs.h |    2 --
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/difs/fonts.c b/difs/fonts.c
index 20ef7f0..0f857ce 100644
--- a/difs/fonts.c
+++ b/difs/fonts.c
@@ -95,14 +95,13 @@ FontToFSError(int err)
     }
 }
 
-/* XXX -- these two funcs may want to be broken into macros */
-void
+static inline void
 UseFPE(FontPathElementPtr fpe)
 {
     fpe->refcount++;
 }
 
-void
+static inline void
 FreeFPE(FontPathElementPtr fpe)
 {
     fpe->refcount--;
diff --git a/include/difs.h b/include/difs.h
index 4b6c216..50f31a2 100644
--- a/include/difs.h
+++ b/include/difs.h
@@ -56,8 +56,6 @@ extern void InitFonts ( void );
 
 /* difs/fonts.c */
 extern int FontToFSError ( int err );
-extern void UseFPE ( FontPathElementPtr fpe );
-extern void FreeFPE ( FontPathElementPtr fpe );
 extern void QueueFontWakeup ( FontPathElementPtr fpe );
 extern void RemoveFontWakeup ( FontPathElementPtr fpe );
 extern void FontWakeup ( pointer data, int count, unsigned long *LastSelectMask );
-- 
1.7.9.2



More information about the xorg-devel mailing list