[PATCH] os/osinit: Allow builders to --disable-segv-handler

Colin Walters walters at verbum.org
Mon Jan 21 11:48:47 PST 2013

On Mon, 2013-01-21 at 09:52 -0800, Keith Packard wrote:

> I think it's relevant for any environment -- if the server does nothing at
> shutdown, then you're generally left on a console in graphics mode which
> makes it pretty hard to use the machine unless some daemon takes over
> and recovers the system for you.

There's some circularity here, because the primary motivation of my
patch is to make it easy to detect X crashes inside my qemu-based
automated testing framework, before those crashes make it to actual
humans =)

But it's a good point.  Perhaps the right thing is to leave this burden
up to the display manager, which is probably what you were thinking when
you wrote:

> That's why I think having this as an option, either in the config file
> or the command line, might be more useful for most people. While most
> people use a display manager, there are still a number of situations
> where 'startx' makes sense.

Ah, well I ship Xorg without the setuid bit, so the answer then is "you
always use a display manager".   I think everyone who ships with Xorg
setuid is insane, basically...

> No argument there; having the server do less when it crashes would
> definitely be a good idea. For KMS devices, all that is really necessary
> is to get the console back to cooked mode and exit, I think.

Hrm, so then are you arguing for a patch which attempts to detect this
situation inside say AbortServer() and shortcuts to just doing that?

More information about the xorg-devel mailing list