[PATCH:libXv] Remove fallback for _XEatDataWords, require libX11 1.6 for it

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jul 5 21:23:22 PDT 2013


_XEatDataWords was orignally introduced with the May 2013 security
patches, and in order to ease the process of delivering those,
fallback versions of _XEatDataWords were included in the X extension
library patches so they could be applied to older versions that didn't
have libX11 1.6 yet.   Now that we're past that hurdle, we can drop
the fallbacks and just require libX11 1.6 for building new versions
of the extension libraries.

Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
 configure.ac |    8 +-------
 src/Xv.c     |   12 ------------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/configure.ac b/configure.ac
index 93c326d..c154f1a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,13 +41,7 @@ XORG_DEFAULT_OPTIONS
 XORG_CHECK_MALLOC_ZERO
 
 # Obtain compiler/linker options for depedencies
-PKG_CHECK_MODULES(XV, [x11 >= 1.5 xext xextproto videoproto])
-
-# Check for _XEatDataWords function that may be patched into older Xlib release
-SAVE_LIBS="$LIBS"
-LIBS="$XV_LIBS"
-AC_CHECK_FUNCS([_XEatDataWords])
-LIBS="$SAVE_LIBS"
+PKG_CHECK_MODULES(XV, [x11 >= 1.6 xext xextproto videoproto])
 
 # Allow checking code with lint, sparse, etc.
 XORG_WITH_LINT
diff --git a/src/Xv.c b/src/Xv.c
index d3e3373..e47093a 100644
--- a/src/Xv.c
+++ b/src/Xv.c
@@ -60,18 +60,6 @@ SOFTWARE.
 #include <X11/extensions/XShm.h>
 #include <limits.h>
 
-#ifndef HAVE__XEATDATAWORDS
-static inline void
-_XEatDataWords(Display *dpy, unsigned long n)
-{
-# ifndef LONG64
-    if (n >= (ULONG_MAX >> 2))
-        _XIOError(dpy);
-# endif
-    _XEatData(dpy, n << 2);
-}
-#endif
-
 static XExtensionInfo _xv_info_data;
 static XExtensionInfo *xv_info = &_xv_info_data;
 static const char *xv_extension_name = XvName;
-- 
1.7.9.2



More information about the xorg-devel mailing list