[PATCH xsetroot] The name of the programe should be replaced once.

Alan Coopersmith alan.coopersmith at oracle.com
Sun Jul 7 10:45:33 PDT 2013


On 07/ 6/13 06:56 PM, Stéphane Aulery wrote:
> Signed-off-by: Stéphane Aulery <lkppo at free.fr>
> ---
>   xsetroot.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xsetroot.c b/xsetroot.c
> index 2eb3a40..73ab1c5 100644
> --- a/xsetroot.c
> +++ b/xsetroot.c
> @@ -73,7 +73,7 @@ static Pixmap ReadBitmapFile(char *filename, unsigned int *width, unsigned int *
>   static void
>   usage(void)
>   {
> -    fprintf(stderr, "usage: %s [options]\n%s\n", program_name,
> +    fprintf(stderr, "usage: %s [options]\n", program_name,
>               "  where options are:\n"
>               "  -help                           Print this help\n"
>               "  -version                        Print a version message\n"
>

Umm, this patch breaks the help message by not printing the options list (the
first %s prints the program_name, the second one the following string with the
options in), so this patch is NAK'ed.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list