[wiz at NetBSD.org: [PATCH:xf86-video-glint] Fix DDC2 on PGX32/Raptor 8P]

[Alan]

I took a quick look and it seems that this bit doesn't exist on PM3, 
only PM2.

Can you test this alternative patch ?

Thanks,

Alan.

On 07/11/13 10:31, Thomas Klausner wrote:
> Hi!
>
> You're the maintainer according to
> http://cgit.freedesktop.org/xorg/doc/xorg-docs/tree/MAINTAINERS
>
> Can you please take a look at and merge the patch?
>
> Thanks,
>   Thomas
>
> ----- Forwarded message from Thomas Klausner <wiz at NetBSD.org> -----
>
> Date: Tue,  4 Jun 2013 12:38:03 +0200
> From: Thomas Klausner <wiz at NetBSD.org>
> To: xorg-devel at lists.x.org
> Cc: Thomas Klausner <wiz at NetBSD.org>
> Subject: [PATCH:xf86-video-glint] Fix DDC2 on PGX32/Raptor 8P
>
> When doing DDC2 on Permedia2 make sure to clear the USE_MONID bit
> in the DDCdata register so the i2c bits actually do something.
>  From Michael Lorez <macallan at NetBSD.org>
> ---
>   src/pm2_dac.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/pm2_dac.c b/src/pm2_dac.c
> index 85093ff..71a1ff0 100644
> --- a/src/pm2_dac.c
> +++ b/src/pm2_dac.c
> @@ -458,8 +458,9 @@ Permedia2I2CPutBits(I2CBusPtr b, int scl, int sda)
>   {
>       GLINTPtr pGlint = (GLINTPtr) b->DriverPrivate.ptr;
>       int r = (pGlint->DDCBus == b) ? PMDDCData : VSSerialBusControl;
> -    CARD32 v = GLINT_READ_REG(r) & ~(ClkOut | DataOut);
>   
> +    CARD32 v = 0;
> +
>       if (scl > 0) v |= ClkOut;
>       if (sda > 0) v |= DataOut;
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pm2.patch
Type: text/x-patch
Size: 920 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130711/5f1bacd8/attachment-0001.bin>