[PATCH libX11] Always initialise thread support

Jamey Sharp jamey at minilop.net
Fri Jul 12 18:22:59 PDT 2013


On Fri, Jul 12, 2013 at 05:09:00PM -0700, Alan Coopersmith wrote:
> On 07/12/13 03:16 PM, Daniel Stone wrote:
> >The immediate provocation was the Mali GLES/EGL implementation, which
> >uses multiple threads itself, and thus relies on XInitThreads having
> >been called somewhere; so if you ever use that specific
> >implementation, every app has to call XInitThreads first to ensure it
> >doesn't die horribly.
> 
> I don't know that it's any saner, but the patches we carried in the Solaris
> libX11 for years to allow libraries to be thread safe even when calling
> apps are not are posted, along with description, at:
> 
> http://people.freedesktop.org/~alanc/thread-fixes/
> 
> Unfortunately, I never got around to trying to figure out if these
> would be good to push upstream or not.

I think the first one looks like a reasonable idea, though I'd have to
think very hard to decide if it's correct.

http://people.freedesktop.org/~alanc/thread-fixes/#1234757

But as the second patch demonstrates, the first one could be opening up
a wide variety of other issues.

http://people.freedesktop.org/~alanc/thread-fixes/#4010755

Patch three looks crazy at first glance, and is probably superceded by
the fix for #1182, as you noted.

http://people.freedesktop.org/~alanc/thread-fixes/#4041914

Patch four seems unrelated to the current discussion, but sounds like a
plausible patch based on the description.

http://people.freedesktop.org/~alanc/thread-fixes/#4614834

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130712/149b2d09/attachment-0001.pgp>


More information about the xorg-devel mailing list