[PATCH] Fix xf86DeleteDriver and various places that use it

Christopher James Halse Rogers chris at cooperteam.net
Thu Jul 25 18:16:01 PDT 2013


On Mon, 2013-07-22 at 11:03 +0200, Mark Kettenis wrote:
> > From: christopher.halse.rogers at canonical.com
> > Date: Mon, 22 Jul 2013 13:44:46 +1000
> > 
> > From: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> > 
> > Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers at canonical.com>
> 
> Care to elaborate what's actually broken?
> 
> To me this just looks like a somewhat arbitrary change that turns
> xf86DriverList from a sparse array into a non-sparse array at the
> expense of making the implementation more complex.

Hm. When when developing against 1.14 I ran into all sorts of code that
didn't expect a sparse array and SEGVd when deleting a video driver.

But I can't seem to reproduce this now against 1.15, so maybe it got
fixed elsewhere?

I'll investigate further. Maybe this is not needed at all.



More information about the xorg-devel mailing list