[PATCH:xf86-input-keyboard 21/21] Add some NetBSD feature detection code.

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jul 26 18:40:08 PDT 2013


On 07/26/13 02:24 PM, Thomas Klausner wrote:
> +case $host_os in
> +  netbsd*)
> +  case $host in
> +    *i386*|*x86_64*)
> +    OS_FLAGS="$OS_FLAGS -DPCVT_SUPPORT"
> +    ;;
> +    *powerpc-*|*sparc-*|*sparc64-*|*vax-*)
> +    OS_FLAGS="$OS_FLAGS -DDEFAULT_TO_WSKBD"
> +    ;;
> +  esac
> +  case "$(uname -m 2>&1)" in
> +  cats)
> +    OS_FLAGS="$OS_FLAGS -DPCVT_SUPPORT"
> +    ;;
> +  evbarm|sgimips|shark)
> +    OS_FLAGS="$OS_FLAGS -DDEFAULT_TO_WSKBD"
> +    ;;
> +  esac
> +  OS_FLAGS="$OS_FLAGS -DWSCONS_SUPPORT"
> +esac
> +AC_SUBST([OS_FLAGS])
> +

Is there no way to do that in the same manner for all platforms?
It's confusing to set the same flags via the autoconf $host for
some hardware and via uname checks for other hardware.

At the very least it would be nice to have the two inner sets of case
statements use the same levels of indentation as each other.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list