[PATCH 1/2] xfree86: Check for issetugid declaration

[Julien Cristau]

On Sat, Jul 27, 2013 at 23:25:22 +0200, Mark Kettenis wrote:

> > From: Julien Cristau <jcristau at debian.org>
> > Date: Sat, 27 Jul 2013 21:08:28 +0200
> > 
> > Avoids 'implicit function declaration' build error on gnu/kfreebsd.
> 
> That's seriously backwards.  You should make sure the right headers
> get included such that there is a proper function declaration.  Or, as
> a last a resort, if the header files for your OS are broken beyond
> repair, provide a function declaration yourself.  But no using
> issetugid() when it is available is a security risk.
> 
The same thing came up last year for xlib, the answer I got then was
http://lists.debian.org/debian-bsd/2012/04/msg00312.html
With the patch the HAVE_GETRESUID path is used instead.
(I agree having that function in libc but not in any header is weird...)

Cheers,
Julien