[PATCH:xf86-input-keyboard 15/21] Fix Protocol "standard".

Matthieu Herrb matthieu.herrb at laas.fr
Mon Jul 29 14:20:53 PDT 2013


On Sat, Jul 27, 2013 at 02:31:40PM +0200, Mark Kettenis wrote:
> > From: Thomas Klausner <wiz at NetBSD.org>
> > Date: Fri, 26 Jul 2013 23:24:10 +0200
> > 
> > Only default to /dev/wskbd if Protocol is set to wskbd. Now Protocol
> > "standard" should work again.
> 
> That description doesn't really make any sense.  Currently there is no
> default for the "Device" option.  This diff is just adding a default,
> but only for the "wskbd" protocol.  That in itself makes sense and
> /dev/wskbd seems to be a reasonable choice.  Unless of course it was a
> deliberate choice to have no default device, which might make some
> sense to prevent a 2nd X server on the machine stealing the keyboard
> from the 1st one.
> 
> Probably a good idea to give Matthieu Herrb a chance to review the
> diffs in this series.  Nevertheless for this one:
> 
> Reviewed-by: Mark Kettenis <kettenis at openbsd.org>
> 

For the record, I exchanged some messages with Thomas and other NetBSD
developers outside this list. I reviewed Thomas' revised patchset. 

-- 
Matthieu Herrb


More information about the xorg-devel mailing list