[git pull] 1.14 gpu fixes backport

Sérgio Basto sergio at serjux.com
Tue Jul 30 14:06:21 PDT 2013


On Ter, 2013-07-23 at 15:51 +1000, Dave Airlie wrote: 
> > Hi,
> > just to clarify, my email is about 2 mini patches:
> > Patch 1 - https://bugzilla.redhat.com/attachment.cgi?id=772539
> >
> > - formats[i].visual_class = visual_info->class;
> > -        XFree(visual_info);
> > + if (visual_info) {
> > +            formats[i].visual_class = visual_info->class;
> > +            XFree(visual_info);
> > +        }
> >
> > On RedHat bugzilla [1], Alphonse Steiner wrote: "This problem is related
> > to Xephyr. The function 'XGetVisualInfo' returns a NULL pointer, leading
> > to the segfault"
> 
> yeah that one is probably fine,

Alphonse Steiner is the author of this first patch but close his bug as
fixed , so he don't need the patch anymore, more information on : 
https://bugzilla.redhat.com/show_bug.cgi?id=986542

When XGetVisualInfo returns a NULL pointer something is wrong and maybe
we should detect and report that earlier ... 


> >
> > Patch 2 - https://bugs.freedesktop.org/attachment.cgi?id=82364
> >
> > - if (ServerIsNotSeat0())
> > +    if (ServerIsNotSeat0() && foundScreen)
> > and
> > -    if (ServerIsNotSeat0())
> > +    if (ServerIsNotSeat0() && xf86_num_platform_devices > 0)
> 
> this one looks simple, but looks can be deceiving, and I've gotten bitten
> by applying patches in this area without through testing on a few platforms!
> 
> Dave.


Thanks, 
-- 
Sérgio M. B.



More information about the xorg-devel mailing list