[PATCH:xf86-video-glint] when doing DDC2 on Permedia2 make sure to clear the USE_MONID bit in the DDCdata register so the i2c bits actually do something Now DDC2 works on my PGX32 / Raptor 8P

Matt Turner mattst88 at gmail.com
Mon Jun 3 08:47:05 PDT 2013


On Sun, Jun 2, 2013 at 2:41 PM, Thomas Klausner <wiz at netbsd.org> wrote:
> From Michael Lorez <macallan at NetBSD.org>
> ---
>  src/pm2_dac.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/pm2_dac.c b/src/pm2_dac.c
> index 85093ff..b6771a5 100644
> --- a/src/pm2_dac.c
> +++ b/src/pm2_dac.c
> @@ -458,8 +458,14 @@ Permedia2I2CPutBits(I2CBusPtr b, int scl, int sda)
>  {
>      GLINTPtr pGlint = (GLINTPtr) b->DriverPrivate.ptr;
>      int r = (pGlint->DDCBus == b) ? PMDDCData : VSSerialBusControl;
> +/*
> +    This is bogus.
> +    All this line does is to preserve the USE_MONID bit if set which prevents
> +    the i2c bits from doing anything
>      CARD32 v = GLINT_READ_REG(r) & ~(ClkOut | DataOut);
> -
> +*/
> +    CARD32 v = 0;
> +

Not sure I like just commenting out code like this.

Fix the commit title and summary message.


More information about the xorg-devel mailing list