[PATCH] Revert "DRI2: re-allocate DRI2 drawable if pixmap serial changes"

Keith Packard keithp at keithp.com
Wed Jun 5 13:17:17 PDT 2013


Eric Anholt <eric at anholt.net> writes:

> This reverts commit 3209b094a3b1466b579e8020e12a4f3fa78a5f3f.  After a
> long debug session by Paul Berry, it appears that this was the commit
> that has been producing sporadic failures in piglit front buffer
> rendering tests for the last several years.

The essential requirement is that a DRM client receive notification each
time the buffer has changed. DRM2 sends InvalidateBuffers events each
time the window size changes, which matches the semantics of this patch.

I can't see any reason to invalidate the buffer more often than this; I
think we'll have to assume that this bug was actually caused by some
other buffer management bug and that this old patch simply masked the
problem found then.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130605/3f54981b/attachment.pgp>


More information about the xorg-devel mailing list