[PATCH:libpciaccess 2/3] Remove useless extra "const" in "const sometype const * var = value; ". Found using clang -Wduplicate-decl-specifier.

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jun 7 20:50:40 PDT 2013


On 06/ 2/13 01:38 PM, Thomas Klausner wrote:
> ---
>   src/common_interface.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/common_interface.c b/src/common_interface.c
> index 6dccf8e..8eace4e 100644
> --- a/src/common_interface.c
> +++ b/src/common_interface.c
> @@ -268,7 +268,7 @@ pci_device_map_range(struct pci_device *dev, pciaddr_t base,
>
>
>       for (region = 0; region < 6; region++) {
> -        const struct pci_mem_region const* r = &dev->regions[region];
> +        const struct pci_mem_region * r = &dev->regions[region];

Perhaps it was meant to be "const struct pci_mem_region * const r",
in which the second const has a meaning?

Looks like Ian added it in
http://cgit.freedesktop.org/xorg/lib/libpciaccess/commit/?id=c65aa7630802c8dfcc06a20e515ace31ab0d0e48

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list