[PATCH:libXt 1/6] Remove unnecessary clause.

Alan Coopersmith alan.coopersmith at oracle.com
Tue Jun 25 14:18:53 PDT 2013


On 06/25/13 02:13 PM, Mark Kettenis wrote:
>> From: Thomas Klausner <wiz at NetBSD.org>
>> Date: Tue, 25 Jun 2013 23:02:45 +0200
>>
>> len is unsigned and can't be smaller than zero.
>
> But vsnprintf(3) returns a signed integer, which can be -1.

Right, so I guess we either make len be signed, or change the if statement
to "if (len == (Cardinal) -1)".

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list