[PATCH] GLX/DRI2: Do not expose INTEL_swap_event without swap control

Ian Romanick idr at freedesktop.org
Wed Mar 13 11:38:55 PDT 2013


On 03/12/2013 05:10 PM, Zack Rusin wrote:
>> Swap events depent on the implementation of ScheduleSwap. By
>> unconditionally enabling GLX_INTEL_swap_event we're breaking
>> the system with drivers that don't support it because the apps
>> are forever stuck waiting for an event that will never be
>> delivered. So lets enable the extension only if the hooks it
>> depends on are actually there.
>
> Ping. Can someone please review/push this? It's quite important.

I thought someone already gave a R-b on this, or I would have sooner.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Now, if I understand the process correctly, you have to resent the patch 
with these two lines added:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: Keith Packard <keithp at keithp.com>

The last one is important... without it, Keith will never notice your 
patch. :)

> z
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



More information about the xorg-devel mailing list