[PULL] unreviewed patches

Keith Packard keithp at keithp.com
Mon May 6 11:26:10 PDT 2013


Peter Hutterer <peter.hutterer at who-t.net> writes:

>       Xi: fix comment - XI2 grabs aren't keysym grabs

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: send the current axis value in DeviceChangedEvents (#62321)

Reviewed-by: Keith Packard <keithp at keithp.com>

>       Xi: always return BadMatch for XTest devices ChangeDeviceControl requests

(this appears to cover all of the DDX entry points to avoid passing
XTest devices to them)

Reviewed-by: Keith Packard <keithp at keithp.com>

>       If neither HAL nor udev backends are enabled, warn the user

Reviewed-by: Keith Packard <keithp at keithp.com>

>       xkb: free XkbRulesUsed and XkbRulesDflt on extension cleanup

I think this should be done in CloseDownDevices -- XkbDeleteRulesDflts
is already called there, adding a call to your new XkbDeleteRulesUsed
(which looks fine, btw) seems like the right plan.

>       Delete callbacks when extension are closed
>       dix: delete all callbacks before reset

Looks like the second patch makes the first unnecessary?

>       dix: reset the registry before quitting

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: support pnprintf length modifiers for integers

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: support %% in pnprintf

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: support %c in pnprintf

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: complain about unsupported pnprintf directives

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: Use ErrorFSigSafe from FatalError and it's friends

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130506/ee0e3b1f/attachment.pgp>


More information about the xorg-devel mailing list