rendercheck: background should be cleared when drawing trapezoids.

Fri Electron frielectron at gmail.com
Tue May 7 14:29:48 PDT 2013


+1170 tests passed of 1710 total
>> Could remaining failures due to not correcting expected color for other
operators DISJOINT_CLEAR, CONJOINT_CLEAR etc ? Referring to
http://www.x.org/releases/current/doc/renderproto/renderproto.txt ( 8.
Compositing operators table) it seems it should be. Previously I had
published a patch with handling expected color for these operators and I
saw all tests passing. As now this change has been merged attaching rebased
version of that.


On Tue, May 7, 2013 at 9:26 PM, Aaron Plattner <aplattner at nvidia.com> wrote:

> On 05/02/2013 11:45 PM, Søren Sandmann wrote:
> > Vikram Fugro <vfugro at nvidia.com> writes:
> >
> >> Hi all,
> >>
> >> With the recent pixman library, trapezoid drawing on background has
> been fixed
> >> by clearing the background (instead of retaining the color of the
> background).
> >>
> >> I have done the necessary changes in the triangles use case (in
> rendercheck)
> >> for the "color expected" from the background.
> >>
> >> Attaching the patch and the snapshots for reference.
> >
> > Reviewed-by: Søren Sandmann <ssp at redhat.com>
> >
> > See also
> >
> >      http://lists.freedesktop.org/archives/pixman/2013-April/002755.html
> >
> > for some rationale for the change in pixman.
> >
> >
> > Søren
>
> Verified against Xvfb:
>
> $ diff -u old new | diffstat
>  new |23386
> --------------------------------------------------------------------
>  1 file changed, 83 insertions(+), 23303 deletions(-)
> $ diff -u old new | tail -n 3
> -900 tests passed of 1710 total
> +1170 tests passed of 1710 total
>  Successful Groups:
>
> Pushed to git.freedesktop.org:/git/xorg/app/rendercheck
>    313a968..b015a64  master -> master
>
> --
> Aaron
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130508/e3f314a4/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-modify-color-expected-outside-of-the-triangles.patch
Type: application/octet-stream
Size: 9522 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130508/e3f314a4/attachment-0001.obj>


More information about the xorg-devel mailing list