[PATCH 1/2] dix: don't overwrite proximity/focus classes

Dave Airlie airlied at gmail.com
Thu May 9 17:26:52 PDT 2013


On Thu, May 9, 2013 at 2:30 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> InitPointerClassDeviceStruct/InitKeyboardDeviceStruct allocate a
> proximity/focus class, respectively. If a driver calls
> InitFocusClassDeviceStruct or InitProximityClassDeviceStruct beforehand,
> the previously allocated class is overwritten, leaking the memory.
>
> Neither takes a parameter other than the device, so we can simply skip
> initialising it if we already have one.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Reviewed-by: Dave Airlie <airlied at redhat.com>


More information about the xorg-devel mailing list