[PATCH 1/2] Remove 'Readv' interface

Mark Kettenis mark.kettenis at xs4all.nl
Fri Nov 1 08:57:10 CET 2013


> From: Keith Packard <keithp at keithp.com>
> Date: Thu, 31 Oct 2013 13:10:24 -0700
> 
> No-one uses this, so there's no reason for it to be in the library

I don't really think it makes sense to remove Readv but keep Writev.
It's not that you're removing a significant amount of code...

> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  Xtrans.c | 7 -------
>  Xtrans.h | 6 ------
>  2 files changed, 13 deletions(-)
> 
> diff --git a/Xtrans.c b/Xtrans.c
> index 0799f04..ac8b13d 100644
> --- a/Xtrans.c
> +++ b/Xtrans.c
> @@ -866,13 +866,6 @@ TRANS(Write) (XtransConnInfo ciptr, char *buf, int size)
>  }
>  
>  int
> -TRANS(Readv) (XtransConnInfo ciptr, struct iovec *buf, int size)
> -
> -{
> -    return ciptr->transptr->Readv (ciptr, buf, size);
> -}
> -
> -int
>  TRANS(Writev) (XtransConnInfo ciptr, struct iovec *buf, int size)
>  
>  {
> diff --git a/Xtrans.h b/Xtrans.h
> index 2945b2a..1b0af45 100644
> --- a/Xtrans.h
> +++ b/Xtrans.h
> @@ -344,12 +344,6 @@ int TRANS(Write)(
>      int			/* size */
>  );
>  
> -int TRANS(Readv)(
> -    XtransConnInfo,	/* ciptr */
> -    struct iovec *,	/* buf */
> -    int			/* size */
> -);
> -
>  int TRANS(Writev)(
>      XtransConnInfo,	/* ciptr */
>      struct iovec *,	/* buf */
> -- 
> 1.8.4.rc3
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list