[Xcb] [PATCH 6/8] Add event queue splitting

Keith Packard keithp at keithp.com
Thu Nov 7 05:04:01 PST 2013


Uli Schlachter <psychon at znc.in> writes:

> Having written the above, I wonder if the first argument should be a struct
> xcb_extension_t instead of a major number. I think that this would be the first
> function to use a major number like this and it is trivial for the
> implementation to turn the xcb_extension_t into a major number.

That's a good change, removing a bit of code an a few variables from
each call site.

> Oh and: Could you please add if(!se) return; to this function? This could
> simplify the error handling of library users.

Sure.

>
> With this change applied:
>
> Stop listening for a special event. This undoes the effect of
> xcb_register_for_special_xge().
> @param c The xcb connection.
> @param se A value returned from xcb_register_for_special_xge(). NULL is allowed

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131107/6151198e/attachment.pgp>


More information about the xorg-devel mailing list