[PATCH 00/37] Warning fixes (post 1.15 proposed changes)

Keith Packard keithp at keithp.com
Mon Nov 18 07:42:07 PST 2013


Thierry Reding <thierry.reding at gmail.com> writes:

> Of course to make proper use of that, quite a bit of code will need to
> be changed first.

Having miles of compiler warning spam is not helpful though, so we need
to tailor the warning set to those which are actually useful for a
particular project. In this case, X uses the same data structures to
hold both string constants and allocated memory. I can think of lots of
fixes for this, but simply sticking a cast in the free parameter seems
the least invasive to me, while preserving most of the checks. Having to
hack around the -Wcast-qual check with an intermediate cast to
(uintptr_t) seems silly.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131118/e7215046/attachment-0001.pgp>


More information about the xorg-devel mailing list