[PATCH] Allow paths and patterns to be const

Keith Packard keithp at keithp.com
Wed Nov 20 13:04:24 PST 2013


Adam Jackson <ajax at nwnk.net> writes:

> Looks like a reasonable change, but it'd be a little unfortunate to
> break building older server on newer fontsproto, which is what would
> happen if I read you right.

Indeed. The X server does things something like:

        fpe->name = malloc()
        strncpy(fpe->name, fp, len)
        fp->name[len] = '\0';

With 'name' const, this doesn't just generate a warning, it generates an
error...

Obviously we'll need to wait for the X server fixes to land before
pushing the fontsproto changes; one option would be to add patches to
the X server for 1.15 that eliminate the errors?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131120/c0acd5ac/attachment.pgp>


More information about the xorg-devel mailing list