[PATCH] miext: Move SyncShm FDs out of the way of clients

Alan Coopersmith alan.coopersmith at oracle.com
Fri Nov 22 09:34:41 PST 2013


On 11/21/13 10:19 PM, Keith Packard wrote:
> +    newfd = fcntl(fd, F_DUPFD, MAXCLIENTS);

Should probably do something like:

#ifdef F_DUPFD_CLOEXEC
	newfd = fcntl(fd, F_DUPFD_CLOEXEC, MAXCLIENTS);
#else
	newfd = fcntl(fd, F_DUPFD, MAXCLIENTS);
#endif
	if (newfd < 0)
         	return fd;
#ifndef F_DUPFD_CLOEXEC
	fcntl(newfd, F_SETFD, FD_CLOEXEC);
#endif

so that we don't pass all those fds to xkbcomp when we fork it.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list