[PATCH 0/7] Damage cleanups and fixes

Adam Jackson ajax at redhat.com
Mon Sep 2 07:18:55 PDT 2013


The two big functional changes here are 3 and 7.  3 fixes core text
rendering in Xnest if a Damage is registered, since the existing code
rewrites the op to something that Xnest doesn't implement.

7 is an attempt (not especially well tested yet) to fix Damage reports
against windows in the Xinerama case.  The code as it is will effectively
only listen for damage against screenrec 0, which will then be clipped to
the dimensions of that screen's (contribution to the) root window.  The
implementation probably has issues.  I expect that damage to pixmaps will
now be wildly overreported (since pixmaps exist on all backing screenrecs),
and that damage to windows will come in multiple batches when the window
crosses a GPU boundary.  The former seems trivial to fix.  The latter I
think you'd need to handle by changing the damage report function to
merely accumulate the regions, and then actually write out the event...
later.  There's not really a pretty place to do that; FlushCallback,
maybe.

- ajax



More information about the xorg-devel mailing list