[PATCH] xfree86: go further with "legacy" PCI bus probe for non-seat0 seats (#66851)

[Laércio Benedito Sivali de Sousa]

Just found that this patch has been already discussed some time ago (before
my subscrption to the list). Latest Dave Airlie opinion was:

"this one looks simple, but looks can be deceiving, and I've gotten bitten
by applying patches in this area without through testing on a few
platforms!"

http://www.mail-archive.com/xorg-devel@lists.x.org/msg36239.html

CANTATE DOMINO CANTICUM NOVUM
QUIA MIRABILIA FECIT

Laércio


2013/9/6 Laércio de Sousa <lbsousajr at gmail.com>

> This fixes a bug that prevents X.Org from starting properly on,
> e.g., NVIDIA cards with proprietary drivers, when "-seat" option
> is passed with an argument different from "seat0".
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=66851
>
> Signed-off-by: Laércio de Sousa <lbsousajr at gmail.com>
> ---
>  hw/xfree86/common/xf86Bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86Bus.c b/hw/xfree86/common/xf86Bus.c
> index e101537..91af72f 100644
> --- a/hw/xfree86/common/xf86Bus.c
> +++ b/hw/xfree86/common/xf86Bus.c
> @@ -81,7 +81,7 @@ xf86CallDriverProbe(DriverPtr drv, Bool detect_only)
>      if (drv->platformProbe != NULL) {
>          foundScreen = xf86platformProbeDev(drv);
>      }
> -    if (ServerIsNotSeat0())
> +    if (ServerIsNotSeat0() && foundScreen)
>          return foundScreen;
>  #endif
>
> @@ -201,7 +201,7 @@ xf86BusProbe(void)
>  {
>  #ifdef XSERVER_PLATFORM_BUS
>      xf86platformProbe();
> -    if (ServerIsNotSeat0())
> +    if (ServerIsNotSeat0() && xf86_num_platform_devices > 0)
>          return;
>  #endif
>  #ifdef XSERVER_LIBPCIACCESS
> --
> 1.8.1.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130916/527b6934/attachment.html>