[PATCH] Add a return value to load_cursor_argb() to allow it to report failure

[Michael Thayer]

On 04/04/14 20:46, Jasper St. Pierre wrote:
> For qemu, this is handled at the kernel modesetting level with QXL.
> See drmModeSetCursor2.
>
> On Fri, Apr 4, 2014 at 3:30 AM, Michael Thayer
> <michael.thayer at oracle.com <mailto:michael.thayer at oracle.com>>
> wrote:
>> And my question about whether a similar patch for
>> set_cursor_position() would make sense is still open (I assume this
>> is relevant for Qemu too):
>>
>>> VirtualBox can use the host cursor as a hardware cursor for a
>>> guest system, but it can't change its position, so if the guest
>>> wants the cursor anywhere except where the host put it (e.g.
>>> another device controlling it, or the cursor confined to a screen
>>> region) it needs to draw it itself.  Of course,
>>> set_cursor_position() should still be called even after it has
>>> failed once so that we could switch back if the positions matched
>>> again.
Isn't drmModeSetCursor2() for passing through the hot-spot?  I'm not 
sure this would help if the X server wanted to put the cursor in a 
different location to the host pointer, particularly if it didn't change 
the sprite at that time since then drmModeSetCursor2() would not get called.

Regards,

Michael
-- 
ORACLE Deutschland B.V. & Co. KG   Michael Thayer
Werkstrasse 24                     VirtualBox engineering
71384 Weinstadt, Germany           mailto:michael.thayer at oracle.com

Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher