[PATCH xfs] Fix CFLAGS and LDFLAGS for Cygwin/MinGW

[Gaetan Nadon]

On 14-04-06 07:50 PM, Yaakov (Cygwin/X) wrote:
> You're referring to using CFLAGS instead of AM_CFLAGS in automake
> files.  This is appending to (not clobbering) CFLAGS at the configure
> level, which still allows the user to override the settings during
> make (even though it would be a bad idea if they left out these flags).
>
Correct. I am not worried that it will not work. Over the years I have
seen many patches removing the use of CFLAG in modules. I looked in the
current server configuration file and cygwin is the only one using
CFLAGS (-DFD_SETSIZE=256). It tends to confirm that the "Variables
reserved for the users" are indeed observed.

    *3.6 Variables reserved for the user*

    Some Makefile variables are reserved by the GNU Coding Standards for
    the use of the "user"---the person building the package. For
    instance, CFLAGS is one such variable.

    Sometimes package developers are tempted to set user variables such
    as CFLAGS because it appears to make their job easier.


Aside from the automake design point, isn't there a risk when using
"global" C flags (or LD flags) for all makefiles? Name clashing in
#define or picking up a symbol from the wrong library?

Anyway, I leave it up to you. Never really had a chance to discuss this
topic before.

Thanks.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140407/38386105/attachment.html>