glamor regressions with radeonsi (Re: xserver: Branch 'master' - 15 commits)

[Michel Dänzer]

On Mon, 2014-04-07 at 18:33 +0900, Michel Dänzer wrote:
> Test case:
> 
>      1. Start 'naked' Xorg with an xterm: xinit =xterm -- :1 -retro &
>      2. Start xfwm4: DISPLAY=:1 xfwm4 &
>      3. Maximize and unmaximize xterm window
> 
> 
> There are at least two regressions introduced by the latest glamor
> series:
> 
> > commit 3c34dd3603989c0365654ca1b6809395c7f3b169
> > Author: Keith Packard <keithp at keithp.com>
> > Date:   Tue Apr 1 21:15:48 2014 -0700
> > 
> >     glamor: Add glamor_program based poly_text and image_text
> >     
> >     Accelerates text painting with GPU-based geometry computation and stippling
> >     
> >     v2: Simplify get_glyphs, expand single character variable names to
> >         more descriptive ones. (Markus Wick)
> >     v3: Rebase against the glamor_prepare_* un-renaming (changes by anholt).
> >     
> >     Improves x11perf -f8text by 417.908% +/- 11.0144% (n=10)
> >     
> >     Signed-off-by: Keith Packard <keithp at keithp.com>
> >     Signed-off-by: Eric Anholt <eric at anholt.net>
> >     Reviewed-by: Eric Anholt <eric at anholt.net>
> 
> As of this commit, the text in the xterm window is not visible after
> step 1. It only becomes visible after step 2.

I've come to realize it's coincidence that the text appears at step 2:
The problem is that a lot of time is spent in glamor_font_get() ->
glTexSubImage2D(). It would probably be more efficient to pack all the
glyphs in malloc()ed memory and pass that to glTexImage2D() instead.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer