[PATCH 1/2] dmx: Fix memory leak in dmxBELoadFont (#50281)

[Jasper St. Pierre]

Looks good.

Reviewed-by: Jasper St. Pierre <jstpierre at mecheye.net>


On Mon, Apr 7, 2014 at 1:47 PM, Adam Jackson <ajax at redhat.com> wrote:

> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/dmx/dmxfont.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/dmx/dmxfont.c b/hw/dmx/dmxfont.c
> index 6b81826..115422d 100644
> --- a/hw/dmx/dmxfont.c
> +++ b/hw/dmx/dmxfont.c
> @@ -397,12 +397,12 @@ dmxBELoadFont(ScreenPtr pScreen, FontPtr pFont)
>                     "font-path-related options, see the Xdmx man page.\n");
>          }
>
> +        free(goodfps);
>          if (!dmxIgnoreBadFontPaths ||
>              (dmxIgnoreBadFontPaths && dmxSetFontPath(dmxScreen))) {
>              /* We still have errors so return with error */
>              dmxFreeFontPath(fp);
>              XFreeFontPath(oldFontPath);
> -            free(goodfps);
>              return FALSE;
>          }
>      }
> --
> 1.9.0
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140417/d7f8ece8/attachment.html>