[PATCH libXfont] Fix buffer read overrun

Keith Packard keithp at keithp.com
Fri Apr 18 11:43:36 PDT 2014


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> glamor/glamor_xv.c:#define MAKE_ATOM(a) MakeAtom(a, sizeof(a) - 1, TRUE)
> hw/kdrive/src/kinput.c:#define AtomFromName(x) MakeAtom(x, strlen(x), 1)
> xkb/ddxBeep.c:#define   MAKE_ATOM(a)    MakeAtom(a,sizeof(a)-1,TRUE)
> xkb/xkbDflts.h:#define GET_ATOM(d,s)    MakeAtom(s,strlen(s),1)
> xkb/xkbInit.c:#define   CREATE_ATOM(s)  MakeAtom(s,sizeof(s)-1,1)

Those 'sizeof' ones are scary. Maybe MakeAtom could take take '0' as
"use strlen"?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140418/bed36750/attachment.sig>


More information about the xorg-devel mailing list