[PATCH 1/3] glamor: Handle unexpected GetGlyphs results better

Keith Packard keithp at keithp.com
Fri Apr 25 17:49:25 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> You previously said you were going to update the comment here (and the
> commit message), but it doesn't look like that happened.

Oh, right. Sorry.

> I think the bug should just get fixed in libXfont and have the server
> rely on it.

I think we need to fix it both places. If it were just incorrect
rendering, I'd be good with leaving it 'broken' in the server, but the
libXfont bug causes the X server to access uninitialized memory, which
is always a bad plan.

I've already posted the fix to libXfont; when that's in place, we'll
never hit this case and this fix "won't matter".

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140425/a70a2aa8/attachment.sig>


More information about the xorg-devel mailing list