[PATCH 2/2] glamor: Add glamor_copy_fbo_cpu() for CopyArea to non-GPU destination

Eric Anholt eric at anholt.net
Tue Aug 5 09:46:43 PDT 2014


Michel Dänzer <michel at daenzer.net> writes:

> From: Michel Dänzer <michel.daenzer at amd.com>
>
> This provides a speedup e.g. when the destination is an SHM pixmap.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76285
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

> +    glamor_prepare_access(dst, GLAMOR_ACCESS_WO);

Do you actually need the new WO flag?  Given that you're only calling
this when !GLAMOR_PIXMAP_PRIV_HAS_FBO(dst_priv), I think that
glamor_prep_pixmap_box() is always early exiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140805/dccf881d/attachment.sig>


More information about the xorg-devel mailing list