[PATCH 3/3] glamor: Disable GL trapezoid code

Keith Packard keithp at keithp.com
Wed Aug 6 13:12:46 PDT 2014


I can't find any performance benefit to using the GL path and the code
renders this trapezoid incorrectly:

  		                 top: FIXED   29.50
		              bottom: FIXED   30.00
		            left top: POINT    0.00,   29.50
		         left bottom: POINT    0.00,   30.50
		           right top: POINT -127.50,   29.50
		        right bottom: POINT   52.50,   30.00

This should render a solid line from 0,30 to 52,30 but draws nothing.

Signed-off-by: Keith Packard <keithp at keithp.com>
---
 glamor/glamor_priv.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h
index 385c027..f270d16 100644
--- a/glamor/glamor_priv.h
+++ b/glamor/glamor_priv.h
@@ -1063,7 +1063,14 @@ void glamor_xv_render(glamor_port_private *port_priv);
 
 #define GLAMOR_PIXMAP_DYNAMIC_UPLOAD
 #define GLAMOR_GRADIENT_SHADER
+
+/*
+ * The GL trapezoid code has several bugs and
+ * offers no performance benefit. Disable it for now
+ */
+#if 0
 #define GLAMOR_TRAPEZOID_SHADER
+#endif
 #define GLAMOR_TEXTURED_LARGE_PIXMAP 1
 #define WALKAROUND_LARGE_TEXTURE_MAP
 #if 0
-- 
2.0.1



More information about the xorg-devel mailing list