[PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

Takashi Iwai tiwai at suse.de
Fri Aug 15 03:01:53 PDT 2014


At Tue, 12 Aug 2014 16:03:54 -0700,
Keith Packard wrote:
> 
> Robert Ancell <robert.ancell at canonical.com> writes:
> 
> > When using the fb backend at 24bpp it allows a visual with 32 bit
> > depth.
> 
> That's not valid; depth must never be larger than bits per pixel.

Can we put some assert to catch such a bug?

> Please
> fix your driver, don't break the insides of the X server.

Which driver do you mean, X or KMS?  It seems happening on both fbdev
and modesetting X drivers when cirrus/mgag200 KMS is used with 24bpp.


Takashi


More information about the xorg-devel mailing list