[PATCH 1/5] dbe: Call to DDX SwapBuffers requires address of int, not unsigned int

Mark Kettenis mark.kettenis at xs4all.nl
Tue Dec 9 11:52:46 PST 2014


> From: Keith Packard <keithp at keithp.com>
> Date: Tue,  9 Dec 2014 09:30:57 -0800
> 
> When the local types used to walk the DBE request were changed, this
> changed the type of the parameter passed to the DDX SwapBuffers API,
> but there wasn't a matching change in the API definition.
> 
> At this point, with the API frozen, I just stuck a new variable in
> with the correct type. Because we've already bounds-checked nStuff to
> be smaller than UINT32_MAX / sizeof(DbeSwapInfoRec), we know it will
> fit in a signed int without overflow.

Hmm, unless the comment:

            /* We don't have DDX support for DBE anymore */

dbe/dbe.c:DbeExtensionInit() is a lie, I believe this isn't really
part of the external API.

> Signed-off-by: Keith Packard <keithp at keithp.com>

> ---
>  dbe/dbe.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)


More information about the xorg-devel mailing list