[PATCH] modesetting: Don't re-enable the cursor when loading the image

[Keith Packard]

Michel Dänzer <michel at daenzer.net> writes:

> I don't think there's any guarantee that the new cursor image will
> become visible without calling drmModeSetCursor(2), so this solution
> won't work in general (e.g. with virtual hardware). Instead, you need to
> remember whether or not the cursor is currently visible, and only call
> drmModeSetCursor(2)[0] from drmmode_load_cursor_argb when it's
> visible.

Yeah, I was just doing what the Intel driver did. I'll fix it up by
pulling the drmModeSetCursor2 call out to a helper function, tracking
the state of the cursor and calling that helper from both places.

Makes sense. Thanks for your review.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141217/fa98d68d/attachment.sig>