[PATCH] Enable subdir-objects

[Gaetan Nadon]

On 14-02-12 05:50 PM, Gaetan Nadon wrote:
> +AM_INIT_AUTOMAKE([foreign dist-bzip2 subdir-objects])
> > 
This is not a new feature in 1.14, but it has never been used so far.
All 250 X modules have the same line.

If you want to propose this, as it changes all of xserver, you would
have to test all 98 makefiles in xserver. Some of them are fairly
complex and I doubt the change would be easy.

I don't have personal experience with subdir-objects feature, I'll have
a go at it. It's hard to believe that $(top_srcdir) would not work
anymore. There are most likely other changes to do in the makefiles,
other than just turning on the feature.

Ok here is a good explanation, as someone already reported this:

https://bugs.freedesktop.org/show_bug.cgi?id=69874

    New in 1.14:
    ...

      - The next major Automake version (2.0) will unconditionally activate
        the 'subdir-objects' option.  In order to smooth out the transition,
        we now give a warning (in the category 'unsupported') whenever a
        source file is present in a subdirectory but the 'subdir-object' is
        not enabled.  For example, the following usage will trigger such a
        warning:

            bin_PROGRAMS = sub/foo
            sub_foo_SOURCES = sub/main.c sub/bar.c

    Long story short, we can ignore it until 2.0 is out, or
    unconditionally set it in configure.ac. The latter one may be
    preffered in order for us to test and make sure that mesa builds
    correctly, otherwise we'll be badly surprised as automake 2.0 comes
    out (think bleeding edge distros/packagers reporting a dozen of bugs)

Looks like we will have to do something about it, but it can't be
blasting ../../../ by the millions :-)



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140212/9ecdeb94/attachment.html>