[PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

Hans de Goede hdegoede at redhat.com
Thu Jan 23 03:16:44 PST 2014


On 01/19/2014 06:17 PM, Daniel Stone wrote:
> Hi,
> On 18 January 2014 16:27, Hans de Goede <hdegoede at redhat.com> wrote:
>> On 01/17/2014 02:08 PM, Daniel Stone wrote:
>>> On 15 January 2014 14:32, Hans de Goede <hdegoede at redhat.com> wrote:
>>>> With systemd-logind the dbus-core will be used for more then just config.
>>>> This patch also makes the building of the dbus-core and udev no longer
>>>> mutually exclusive and removes the config_ prefix from the dbus-core
>>>> symbols.
>>> The rest of your patchset looks good to me, but I'd rather this not
>>> get moved to hw/xfree86/.  Historically, hw/xfree86/ has been a bit of
>>> a ghetto that we've tried to move things out of, because the majority
>>> of code in there is really terrible.  It also means you can't use HAL
>>> support on non-XFree86 DDXes, which I admit is entirely a theoretical
>>> concern atm, but still ...
>> Suggestions for where it should be moved instead then ? Putting it in the os
>> dir means all kinda binaries which are not using dbus at all start depending
>> on it too... Maybe leave it in config (while keeping the other changes ?
> I'd just leave it in config/ to be honest.

Ok, I've put it back in config (while keeping the other changes like making
it no longer mutually exclusive with udev). I've pushed the updated version here:



More information about the xorg-devel mailing list