[PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

Hans de Goede hdegoede at redhat.com
Tue Jan 28 02:33:01 PST 2014


On 01/23/2014 02:58 PM, Hans de Goede wrote:
> Hi,
> On 01/23/2014 01:56 PM, Daniel Stone wrote:


>> 8d972e0c xf86Xinput: Modify API for server-managed fd support
>>      I worry a little that drivers won't necessarily support this -
>> would be nice to check by forcing them to define
>> I_SUPPORT_SERVER_MANAGED_FDS or something; either that, or extend
>> InputDriverRec with an equivalent flag which must be set.
> Interesting idea, I've investigating this on my todo list for Monday
> (I'm not working tomorrow).

So currently there is no way for drivers to advertise capabilities
which the server can test pre-probe.

Adding these would require adding a capabilities field to InputDriverRec,
not impossible, but thinking more about this I believe this is
undesirable. Having capabilities will typically lead to a combinatiorial
explosion of capability combinations after a while, which I think we should
try to avoid. IOW I think that adding capabilities to internal xserver APIs
is a bad idea.

As for the worries of drivers not being prepared to deal with this,
systemd_logind_take_fd will only succeed for evdev devices, and AFAIK we've
only 2 drivers for those evdev and synaptics. I'll make sure I've changes
for those ready to merge as soon as everyone is happy with the server bits.



More information about the xorg-devel mailing list