[PATCH 3/7] input: un-constify InputAttributes

Peter Hutterer peter.hutterer at who-t.net
Thu Jan 30 15:45:28 PST 2014

On Thu, Jan 30, 2014 at 03:04:41PM +0100, Julien Cristau wrote:
> On Thu, Jan 30, 2014 at 14:57:23 +0100, Hans de Goede wrote:
> > Oops correction I should look closer myself, that is in 2/7 not 3/7 . Anyways
> > I still believe that using XNFstrdup instead would be better. I don't see why
> > sloppy coding (lacking error checking is sloppy coding) would be ok in test
> > cases.
> > 
> I'd expect that either it's ok for these things to be NULL, or the test
> will fail when they are?

correct, it'll crash on strcmp(). though xnfstrdup is simple enough to add
though and it does add that little bit of value that I've just amended


More information about the xorg-devel mailing list