[PATCH 1/4] fb: fix screen pixmap leak on server reset

Julien Cristau jcristau at debian.org
Wed Jul 2 23:34:02 PDT 2014


On Thu, Jun 26, 2014 at 14:15:41 -0700, Keith Packard wrote:

> From: Keith Packard <keithp at keithp.com>
> Date: Thu, 26 Jun 2014 14:12:24 -0700
> Subject: [PATCH] fb: Don't free NULL pixmap in fbCloseScreen. Bug #80313
> 
> We fixed fbCloseScreen to use the FreePixmap function so that the
> private counts would be updated correctly during CloseScreen. Xvfb
> calls FreePixmap and sets devPrivate to NULL before fbCloseScreen is
> called; not checking devPrivate before calling would result in a NULL
> pointer dereference.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  fb/fbscreen.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien


More information about the xorg-devel mailing list